This repository has been archived by the owner on Aug 10, 2020. It is now read-only.
Include name_tag method if name is passed as a parameter to identify #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls because the _analytical_javascript regular expression that converts those __EVENT__ and __PAGE__ to parameter names is dependent on double quotes (cant be single quotes)
|
also fixed the Analytical. js helper for mixpanel. The analytical_javascript partial does a gsub on the EVENT and PAGE params, but requires them to be surrounded by double quotes, not single quotes. |
jkrall
added a commit
that referenced
this pull request
Dec 9, 2011
Include name_tag method if name is passed as a parameter to identify
|
Thanks for this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see there's another pull request for this but I think this is done a bit closer to how you wanted it.